]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
gpio: brcmstb: correct the configuration of level interrupts
authorDoug Berger <opendmb@gmail.com>
Tue, 24 Oct 2017 19:54:49 +0000 (12:54 -0700)
committerLinus Walleij <linus.walleij@linaro.org>
Tue, 31 Oct 2017 09:30:44 +0000 (10:30 +0100)
This commit corrects a bug when configuring the GPIO hardware for
IRQ_TYPE_LEVEL_LOW and IRQ_TYPE_LEVEL_HIGH interrupt types. The
hardware is now correctly configured to support those types.

Fixes: 19a7b6940b78 ("gpio: brcmstb: Add interrupt and wakeup source support")
Signed-off-by: Doug Berger <opendmb@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Acked-by: Gregory Fong <gregory.0xf0@gmail.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-brcmstb.c

index 513de4936a253c62e1ae91d2f41891d1369735dd..183863902f7fc97ebd2543389892f9e807956ac7 100644 (file)
@@ -137,13 +137,13 @@ static int brcmstb_gpio_irq_set_type(struct irq_data *d, unsigned int type)
 
        switch (type) {
        case IRQ_TYPE_LEVEL_LOW:
-               level = 0;
+               level = mask;
                edge_config = 0;
                edge_insensitive = 0;
                break;
        case IRQ_TYPE_LEVEL_HIGH:
                level = mask;
-               edge_config = 0;
+               edge_config = mask;
                edge_insensitive = 0;
                break;
        case IRQ_TYPE_EDGE_FALLING: