]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
[media] media: i2c: m5mols: m5mols_core: constify v4l2_subdev_pad_ops structures
authorBhumika Goyal <bhumirks@gmail.com>
Tue, 13 Dec 2016 11:49:45 +0000 (09:49 -0200)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Fri, 3 Feb 2017 11:28:32 +0000 (09:28 -0200)
v4l2_subdev_pad_ops structures are stored in the pad field
of the v4l2_subdev_ops structure and this field is of type const.
As the v4l2_subdev_pad_ops structures are never modified, they can be
declared as const.
Done using Coccinelle:

@r1 disable optional_qualifier @
identifier i;
position p;
@@
static struct v4l2_subdev_pad_ops i@p = {...};

@ok1@
identifier r1.i;
position p;
struct v4l2_subdev_ops obj;
@@
obj.pad=&i@p;

@bad@
position p!={r1.p,ok1.p};
identifier r1.i;
@@
i@p

@depends on !bad disable optional_qualifier@
identifier r1.i;
@@
+const
struct v4l2_subdev_pad_ops i;

File size before:
 text    data     bss     dec     hex filename
   7633     512      20    8165    1fe5 media/i2c/m5mols/m5mols_core.o

File size after:
  text    data     bss     dec     hex filename
   7761     384      20    8165    1fe5 media/i2c/m5mols/m5mols_core.o

Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/i2c/m5mols/m5mols_core.c

index 23e86164611cbf7485fa405e8bb49960cba10505..9ccb5ee55fa9c845a076ee23bf46220339021df5 100644 (file)
@@ -652,7 +652,7 @@ static int m5mols_enum_mbus_code(struct v4l2_subdev *sd,
        return 0;
 }
 
-static struct v4l2_subdev_pad_ops m5mols_pad_ops = {
+static const struct v4l2_subdev_pad_ops m5mols_pad_ops = {
        .enum_mbus_code = m5mols_enum_mbus_code,
        .get_fmt        = m5mols_get_fmt,
        .set_fmt        = m5mols_set_fmt,