]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
s390/pci: Delete an unnecessary check before the function call "pci_dev_put"
authorMarkus Elfring <elfring@users.sourceforge.net>
Mon, 18 Jul 2016 07:00:00 +0000 (09:00 +0200)
committerMartin Schwidefsky <schwidefsky@de.ibm.com>
Mon, 18 Jul 2016 08:17:24 +0000 (10:17 +0200)
The pci_dev_put() function tests whether its argument is NULL and then
returns immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Signed-off-by: Martin Schwidefsky <schwidefsky@de.ibm.com>
arch/s390/pci/pci_event.c

index fb2a9a560fdcfc1e414e823563d436a4ebdc90af..c2b27ad8e94dd07b4983d2dd5bee8c49fa94eb8c 100644 (file)
@@ -145,8 +145,7 @@ static void __zpci_event_availability(struct zpci_ccdf_avail *ccdf)
        default:
                break;
        }
-       if (pdev)
-               pci_dev_put(pdev);
+       pci_dev_put(pdev);
 }
 
 void zpci_event_availability(void *data)