]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
Staging: irda: drivers: Replace (skb == NULL) with (!skb)
authorMeghana Madhyastha <meghana.madhyastha@gmail.com>
Fri, 15 Sep 2017 09:13:15 +0000 (14:43 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 18 Sep 2017 09:52:36 +0000 (11:52 +0200)
Some functions return NULL as an indication of failure.
The style (!skb) is more common than (skb == NULL) for these
functions.

Found by the following Coccinelle script.

@@
identifier i;
statement S;
@@

i = (\(kmalloc\|devm_kzalloc\|kmalloc_array\|devm_ioremap\|usb_alloc_urb\|
alloc_netdev\|dev_alloc_skb\)(...));

(
-if (i == NULL)
+if (!i)
S
|
-if (NULL == i)
+if (!i)
S
)

Signed-off-by: Meghana Madhyastha <meghana.madhyastha@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/irda/drivers/ali-ircc.c

index 35f198d8370140a78f0390857c12ed68f8a165c6..756ae53dc1ecd7f9d79e7c9c8313408667796b7a 100644 (file)
@@ -1876,7 +1876,7 @@ static int  ali_ircc_dma_receive_complete(struct ali_ircc_cb *self)
                        self->stamp = ktime_get();
 
                        skb = dev_alloc_skb(len+1);
-                       if (skb == NULL)  
+                       if (!skb)
                        {
                                self->netdev->stats.rx_dropped++;