]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
libnvdimm, namespace: make a couple of functions static
authorColin Ian King <colin.king@canonical.com>
Thu, 5 Oct 2017 09:55:57 +0000 (10:55 +0100)
committerDan Williams <dan.j.williams@intel.com>
Sat, 7 Oct 2017 17:04:06 +0000 (10:04 -0700)
The functions create_namespace_pmem and create_namespace_blk are local
to the source and do not need to be in global scope, so make them static.

Cleans up sparse warnings:
symbol 'create_namespace_pmem' was not declared. Should it be static?
symbol 'create_namespace_blk' was not declared. Should it be static?

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
drivers/nvdimm/namespace_devs.c

index 0af988739a06c1195b1335ab29f54d9b9752c591..bb3ba8cf24d4503801f3534f01a0e1f86cb7a641 100644 (file)
@@ -1875,7 +1875,7 @@ static int select_pmem_id(struct nd_region *nd_region, u8 *pmem_id)
  * @nspm: target namespace to create
  * @nd_label: target pmem namespace label to evaluate
  */
-struct device *create_namespace_pmem(struct nd_region *nd_region,
+static struct device *create_namespace_pmem(struct nd_region *nd_region,
                struct nd_namespace_index *nsindex,
                struct nd_namespace_label *nd_label)
 {
@@ -2186,7 +2186,7 @@ static int add_namespace_resource(struct nd_region *nd_region,
        return i;
 }
 
-struct device *create_namespace_blk(struct nd_region *nd_region,
+static struct device *create_namespace_blk(struct nd_region *nd_region,
                struct nd_namespace_label *nd_label, int count)
 {