]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
mmc: jz4740: Code cleanup
authorPaul Cercueil <paul@crapouillou.net>
Sat, 10 Aug 2019 12:16:07 +0000 (14:16 +0200)
committerUlf Hansson <ulf.hansson@linaro.org>
Wed, 11 Sep 2019 13:58:39 +0000 (15:58 +0200)
Fix wrong code indentation which made the code hard to read, and fix
return with value in void function.

Signed-off-by: Paul Cercueil <paul@crapouillou.net>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/jz4740_mmc.c

index 672708543a117d39399c3ecc431e5d2224b2392a..037b8b75fb4cda936e6e880c8aaebb3ef6ef04e7 100644 (file)
@@ -186,9 +186,9 @@ static void jz4740_mmc_write_irq_reg(struct jz4740_mmc_host *host,
                                     uint32_t val)
 {
        if (host->version >= JZ_MMC_JZ4780)
-               return writel(val, host->base + JZ_REG_MMC_IREG);
+               writel(val, host->base + JZ_REG_MMC_IREG);
        else
-               return writew(val, host->base + JZ_REG_MMC_IREG);
+               writew(val, host->base + JZ_REG_MMC_IREG);
 }
 
 static uint32_t jz4740_mmc_read_irq_reg(struct jz4740_mmc_host *host)
@@ -820,14 +820,14 @@ static irqreturn_t jz_mmc_irq(int irq, void *devid)
                        del_timer(&host->timeout_timer);
 
                        if (status & JZ_MMC_STATUS_TIMEOUT_RES) {
-                                       cmd->error = -ETIMEDOUT;
+                               cmd->error = -ETIMEDOUT;
                        } else if (status & JZ_MMC_STATUS_CRC_RES_ERR) {
-                                       cmd->error = -EIO;
+                               cmd->error = -EIO;
                        } else if (status & (JZ_MMC_STATUS_CRC_READ_ERROR |
                                    JZ_MMC_STATUS_CRC_WRITE_ERROR)) {
-                                       if (cmd->data)
-                                                       cmd->data->error = -EIO;
-                                       cmd->error = -EIO;
+                               if (cmd->data)
+                                       cmd->data->error = -EIO;
+                               cmd->error = -EIO;
                        }
 
                        jz4740_mmc_set_irq_enabled(host, irq_reg, false);