]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
drm/i915/gvt: do not let pin count of shadow mm go negative
authorYan Zhao <yan.y.zhao@intel.com>
Wed, 27 Mar 2019 04:55:45 +0000 (00:55 -0400)
committerZhenyu Wang <zhenyuw@linux.intel.com>
Fri, 29 Mar 2019 02:27:42 +0000 (10:27 +0800)
shadow mm's pin count got increased in workload preparation phase, which
is after workload scanning.
it will get decreased in complete_current_workload() anyway after
workload completion.
Sometimes, if a workload meets a scanning error, its shadow mm pin count
will not get increased but will get decreased in the end.
This patch lets shadow mm's pin count not go below 0.

Fixes: 2707e4446688 ("drm/i915/gvt: vGPU graphics memory virtualization")
Cc: zhenyuw@linux.intel.com
Cc: stable@vger.kernel.org #4.14+
Signed-off-by: Yan Zhao <yan.y.zhao@intel.com>
Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com>
drivers/gpu/drm/i915/gvt/gtt.c

index d7052ab7908c8d9c7872df64cb5cd68ec8f13b4e..cf133ef038735d64e6655b78c087992f5f1d1984 100644 (file)
@@ -1946,7 +1946,7 @@ void _intel_vgpu_mm_release(struct kref *mm_ref)
  */
 void intel_vgpu_unpin_mm(struct intel_vgpu_mm *mm)
 {
-       atomic_dec(&mm->pincount);
+       atomic_dec_if_positive(&mm->pincount);
 }
 
 /**