]> asedeno.scripts.mit.edu Git - PuTTY.git/commitdiff
Fix faulty length fields in pageant_get_keylist*().
authorSimon Tatham <anakin@pobox.com>
Mon, 11 May 2015 16:52:45 +0000 (17:52 +0100)
committerSimon Tatham <anakin@pobox.com>
Mon, 11 May 2015 16:53:06 +0000 (17:53 +0100)
Those must have been wrong _forever_, but because Windows Pageant
doesn't mind if the message length is longer than it should be, I've
never noticed before. How embarrassing.

pageant.c

index 76e5911aab83e36a6f2d6d0b89e0c16a51b45400..51baab02fd434edd4c301e6a19f38b9200c45a75 100644 (file)
--- a/pageant.c
+++ b/pageant.c
@@ -1207,7 +1207,7 @@ void *pageant_get_keylist1(int *length)
        void *vresponse;
        int resplen, retval;
        request[4] = SSH1_AGENTC_REQUEST_RSA_IDENTITIES;
-       PUT_32BIT(request, 4);
+       PUT_32BIT(request, 1);
 
        retval = agent_query(request, 5, &vresponse, &resplen, NULL, NULL);
        assert(retval == 1);
@@ -1239,7 +1239,7 @@ void *pageant_get_keylist2(int *length)
        int resplen, retval;
 
        request[4] = SSH2_AGENTC_REQUEST_IDENTITIES;
-       PUT_32BIT(request, 4);
+       PUT_32BIT(request, 1);
 
        retval = agent_query(request, 5, &vresponse, &resplen, NULL, NULL);
        assert(retval == 1);