]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
mmc: au1xmmc: switch to platform_get_irq
authorYangtao Li <tiny.windzz@gmail.com>
Sun, 15 Dec 2019 17:51:20 +0000 (17:51 +0000)
committerUlf Hansson <ulf.hansson@linaro.org>
Wed, 18 Dec 2019 13:55:11 +0000 (14:55 +0100)
platform_get_resource(pdev, IORESOURCE_IRQ) is not recommended for
requesting IRQ's resources, as they can be not ready yet. Using
platform_get_irq() instead is preferred for getting IRQ even if it
was not retrieved earlier.

Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Link: https://lore.kernel.org/r/20191215175120.3290-13-tiny.windzz@gmail.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/au1xmmc.c

index bc8aeb47a7b48f9ba5d0f6c66565b990419d6f39..8823680ca42c97514d1024cd929bc5c4e5dd1606 100644 (file)
@@ -984,12 +984,9 @@ static int au1xmmc_probe(struct platform_device *pdev)
                goto out2;
        }
 
-       r = platform_get_resource(pdev, IORESOURCE_IRQ, 0);
-       if (!r) {
-               dev_err(&pdev->dev, "no IRQ defined\n");
+       host->irq = platform_get_irq(pdev, 0);
+       if (host->irq < 0)
                goto out3;
-       }
-       host->irq = r->start;
 
        mmc->ops = &au1xmmc_ops;