]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
[media] mantis: get rid of warning: no previous prototype
authorMauro Carvalho Chehab <mchehab@redhat.com>
Sat, 27 Oct 2012 16:00:58 +0000 (13:00 -0300)
committerMauro Carvalho Chehab <mchehab@redhat.com>
Sat, 27 Oct 2012 20:05:22 +0000 (18:05 -0200)
drivers/media/pci/mantis/mantis_input.c:107:5: warning: no previous prototype for 'mantis_input_init' [-Wmissing-prototypes]
drivers/media/pci/mantis/mantis_input.c:153:5: warning: no previous prototype for 'mantis_exit' [-Wmissing-prototypes]
drivers/media/pci/mantis/mantis_uart.c:64:5: warning: no previous prototype for 'mantis_uart_read' [-Wmissing-prototypes]
drivers/media/pci/mantis/mantis_vp1033.c:118:5: warning: no previous prototype for 'lgtdqcs001f_set_symbol_rate' [-Wmissing-prototypes]
drivers/media/pci/mantis/mantis_vp1033.c:86:5: warning: no previous prototype for 'lgtdqcs001f_tuner_set' [-Wmissing-prototypes]

Note: there is already a mantis_exit at the mantis driver. So,
this should be renamed to mantis_input_exit.

The mantis_input code is currently unused, as it doesn't implement the RC API
right.

Patches for it are sent for discussions, but were never
accepted. So, while this is not fixed, the entire code inside
mantis_input can simply be commented.

Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
drivers/media/pci/mantis/mantis_input.c
drivers/media/pci/mantis/mantis_uart.c
drivers/media/pci/mantis/mantis_vp1033.c

index db6d54d3fec0497ddaf61cfda0d092bf1ffc2e02..0e5252e5c0ef86e1a0ce4af1d25ee9d52dc7aa42 100644 (file)
@@ -18,6 +18,8 @@
        Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
 */
 
+#if 0 /* Currently unused */
+
 #include <media/rc-core.h>
 #include <linux/pci.h>
 
@@ -150,10 +152,11 @@ int mantis_input_init(struct mantis_pci *mantis)
        return err;
 }
 
-int mantis_exit(struct mantis_pci *mantis)
+int mantis_init_exit(struct mantis_pci *mantis)
 {
        rc_unregister_device(mantis->rc);
        rc_map_unregister(&ir_mantis_map);
        return 0;
 }
 
+#endif
index 85e977861b4a68a8bbb44d76c9b6a010ec250c3f..a7071921863194d07b5542c5564c4f26c4af6cda 100644 (file)
@@ -61,7 +61,7 @@ static struct {
 
 #define UART_MAX_BUF                   16
 
-int mantis_uart_read(struct mantis_pci *mantis, u8 *data)
+static int mantis_uart_read(struct mantis_pci *mantis, u8 *data)
 {
        struct mantis_hwconfig *config = mantis->hwconfig;
        u32 stat = 0, i;
index ad013e93ed11d7bd05638ebf7eb5a398c4631244..115003e8d19d453f30a2db59664d3a561c614116 100644 (file)
@@ -83,7 +83,7 @@ u8 lgtdqcs001f_inittab[] = {
 #define MANTIS_MODEL_NAME      "VP-1033"
 #define MANTIS_DEV_TYPE                "DVB-S/DSS"
 
-int lgtdqcs001f_tuner_set(struct dvb_frontend *fe)
+static int lgtdqcs001f_tuner_set(struct dvb_frontend *fe)
 {
        struct dtv_frontend_properties *p = &fe->dtv_property_cache;
        struct mantis_pci *mantis       = fe->dvb->priv;
@@ -115,8 +115,8 @@ int lgtdqcs001f_tuner_set(struct dvb_frontend *fe)
        return 0;
 }
 
-int lgtdqcs001f_set_symbol_rate(struct dvb_frontend *fe,
-                               u32 srate, u32 ratio)
+static int lgtdqcs001f_set_symbol_rate(struct dvb_frontend *fe,
+                                      u32 srate, u32 ratio)
 {
        u8 aclk = 0;
        u8 bclk = 0;