]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
Bluetooth: 6lowpan: always check destination address
authorJosua Mayer <josua.mayer@jm0.eu>
Sat, 6 Jul 2019 15:54:48 +0000 (17:54 +0200)
committerMarcel Holtmann <marcel@holtmann.org>
Sat, 6 Jul 2019 19:33:55 +0000 (21:33 +0200)
BLE based 6LoWPAN networks are highly constrained in bandwidth.
Do not take a short-cut, always check if the destination address is
known to belong to a peer.

As a side-effect this also removes any behavioral differences between
one, and two or more connected peers.

Acked-by: Jukka Rissanen <jukka.rissanen@linux.intel.com>
Tested-by: Michael Scott <mike@foundries.io>
Signed-off-by: Josua Mayer <josua.mayer@jm0.eu>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
net/bluetooth/6lowpan.c

index f4e548e7b985365e2946a6f39829e8d8e5f83f3f..9d41de1ec90f687ea9ad249c7ede9a5e37f86968 100644 (file)
@@ -168,18 +168,6 @@ static inline struct lowpan_peer *peer_lookup_dst(struct lowpan_btle_dev *dev,
 
        BT_DBG("peers %d addr %pI6c rt %p", count, daddr, rt);
 
-       /* If we have multiple 6lowpan peers, then check where we should
-        * send the packet. If only one peer exists, then we can send the
-        * packet right away.
-        */
-       if (count == 1) {
-               rcu_read_lock();
-               peer = list_first_or_null_rcu(&dev->peers, struct lowpan_peer,
-                                             list);
-               rcu_read_unlock();
-               return peer;
-       }
-
        if (!rt) {
                if (ipv6_addr_any(&lowpan_cb(skb)->gw)) {
                        /* There is neither route nor gateway,