]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
staging: rtl8723bs: remove set but not used variable 'pHalData', 'pdmpriv'
authorzhengbin <zhengbin13@huawei.com>
Mon, 18 Nov 2019 07:45:53 +0000 (15:45 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 18 Nov 2019 11:49:41 +0000 (12:49 +0100)
Fixes gcc '-Wunused-but-set-variable' warning:

drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c: In function rtl8723b_InitAntenna_Selection:
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c:2237:23: warning: variable pHalData set but not used [-Wunused-but-set-variable]
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c: In function rtl8723b_fill_default_txdesc:
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c:3056:18: warning: variable pdmpriv set but not used [-Wunused-but-set-variable]

They are introduced by commit 554c0a3abf21 ("staging:
Add rtl8723bs sdio wifi driver"), but never used, so remove them.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: zhengbin <zhengbin13@huawei.com>
Link: https://lore.kernel.org/r/1574063156-68155-3-git-send-email-zhengbin13@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c

index 22931ab3a5fc3b3fc205c9c3add0f50f49574b0b..66127f6c8e4db3e4abe425342f5f346d033e7a3f 100644 (file)
@@ -2234,12 +2234,8 @@ void rtl8723b_set_hal_ops(struct hal_ops *pHalFunc)
 
 void rtl8723b_InitAntenna_Selection(struct adapter *padapter)
 {
-       struct hal_com_data *pHalData;
        u8 val;
 
-
-       pHalData = GET_HAL_DATA(padapter);
-
        val = rtw_read8(padapter, REG_LEDCFG2);
        /*  Let 8051 take control antenna settting */
        val |= BIT(7); /*  DPDT_SEL_EN, 0x4C[23] */
@@ -3053,7 +3049,6 @@ static void rtl8723b_fill_default_txdesc(
 {
        struct adapter *padapter;
        struct hal_com_data *pHalData;
-       struct dm_priv *pdmpriv;
        struct mlme_ext_priv *pmlmeext;
        struct mlme_ext_info *pmlmeinfo;
        struct pkt_attrib *pattrib;
@@ -3064,7 +3059,6 @@ static void rtl8723b_fill_default_txdesc(
 
        padapter = pxmitframe->padapter;
        pHalData = GET_HAL_DATA(padapter);
-       pdmpriv = &pHalData->dmpriv;
        pmlmeext = &padapter->mlmeextpriv;
        pmlmeinfo = &(pmlmeext->mlmext_info);