]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
iwlwifi: dbg_ini: set dump bit only when trigger collection is certain
authorShahar S Matityahu <shahar.s.matityahu@intel.com>
Tue, 19 Mar 2019 07:35:29 +0000 (09:35 +0200)
committerLuca Coelho <luciano.coelho@intel.com>
Fri, 19 Apr 2019 07:27:34 +0000 (10:27 +0300)
In case the the trigger occurrences is zero or force_restart is set, the
driver sets IWL_FWRT_STATUS_DUMPING without actually scheduling trigger
collection. At this point no other dump collection can be performed.

Solve this by setting IWL_FWRT_STATUS_DUMPING bit only when the driver
is surely going to schedule dump collection

Signed-off-by: Shahar S Matityahu <shahar.s.matityahu@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
drivers/net/wireless/intel/iwlwifi/fw/dbg.c

index d070c2c220769d800006e900ce952647541584a1..79e36336f623bc56101ac3603b7b10cf839e35ee 100644 (file)
@@ -2145,6 +2145,9 @@ int _iwl_fw_dbg_ini_collect(struct iwl_fw_runtime *fwrt,
                return 0;
        }
 
+       if (test_and_set_bit(IWL_FWRT_STATUS_DUMPING, &fwrt->status))
+               return -EBUSY;
+
        fwrt->dump.ini_trig_id = id;
 
        IWL_WARN(fwrt, "WRT: collecting data: ini trigger %d fired.\n", id);