]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
spi: nxp-fspi: Use devm API to fix missed unregistration of controller
authorChuhong Yuan <hslester96@gmail.com>
Sat, 9 Nov 2019 07:55:17 +0000 (15:55 +0800)
committerMark Brown <broonie@kernel.org>
Mon, 11 Nov 2019 12:50:48 +0000 (12:50 +0000)
This driver forgets to unregister controller when remove.
Use devm API to unregister it automatically to fix it.

Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Link: https://lore.kernel.org/r/20191109075517.29988-1-hslester96@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-nxp-fspi.c

index 501b923f2c27ade9f060d0e368f5f2e0e771f808..c36bb1bb464e60de23c466d700cff0c3ef1f02c6 100644 (file)
@@ -1027,7 +1027,7 @@ static int nxp_fspi_probe(struct platform_device *pdev)
 
        ctlr->dev.of_node = np;
 
-       ret = spi_register_controller(ctlr);
+       ret = devm_spi_register_controller(&pdev->dev, ctlr);
        if (ret)
                goto err_destroy_mutex;