]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
media: ngene: Remove call to memset after pci_alloc_consistent
authorFuqian Huang <huangfq.daxian@gmail.com>
Mon, 15 Jul 2019 03:18:44 +0000 (00:18 -0300)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Tue, 13 Aug 2019 14:54:39 +0000 (11:54 -0300)
pci_alloc_consistent calls dma_alloc_coherent directly.
In commit 518a2f1925c3
("dma-mapping: zero memory returned from dma_alloc_*"),
dma_alloc_coherent has already zeroed the memory.
So memset is not needed.

Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/pci/ngene/ngene-core.c

index b75ab7d29226631a9b442c06ad9c68772c90951d..af15ca1c501bf47fb87e408267e72a4d93a8d73d 100644 (file)
@@ -854,8 +854,6 @@ static int create_ring_buffer(struct pci_dev *pci_dev,
        if (!Head)
                return -ENOMEM;
 
-       memset(Head, 0, MemSize);
-
        PARingBufferCur = PARingBufferHead;
        Cur = Head;
 
@@ -907,8 +905,6 @@ static int AllocateRingBuffers(struct pci_dev *pci_dev,
        if (SCListMem == NULL)
                return -ENOMEM;
 
-       memset(SCListMem, 0, SCListMemSize);
-
        pRingBuffer->SCListMem = SCListMem;
        pRingBuffer->PASCListMem = PASCListMem;
        pRingBuffer->SCListMemSize = SCListMemSize;