dmaengine: qcom_hidma: fix return value check in hidma_mgmt_of_populate_channels()

In case of error, the function platform_device_register_full()
returns ERR_PTR() and never returns NULL. The NULL test in the
return value check should be replaced with IS_ERR().

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>

diff --git a/drivers/dma/qcom/hidma_mgmt.c b/drivers/dma/qcom/hidma_mgmt.c
index c0e365321310009a6df4443b173a9f7823438a4d..6416dededd67938390df091c831dcb30c57aa071 100644 (file)
--- a/drivers/dma/qcom/hidma_mgmt.c
+++ b/drivers/dma/qcom/hidma_mgmt.c
@@ -371,8 +371,8 @@ static int __init hidma_mgmt_of_populate_channels(struct device_node *np)
                pdevinfo.size_data = 0;
                pdevinfo.dma_mask = DMA_BIT_MASK(64);
                new_pdev = platform_device_register_full(&pdevinfo);
-               if (!new_pdev) {
-                       ret = -ENODEV;
+               if (IS_ERR(new_pdev)) {
+                       ret = PTR_ERR(new_pdev);
                        goto out;
                }
                of_dma_configure(&new_pdev->dev, child);