]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
powerpc32/booke: consistently return phys_addr_t in __pa()
authorBai Yingjie <byj.tea@gmail.com>
Mon, 6 Jan 2020 04:29:53 +0000 (12:29 +0800)
committerMichael Ellerman <mpe@ellerman.id.au>
Tue, 7 Jan 2020 11:05:51 +0000 (22:05 +1100)
When CONFIG_RELOCATABLE=y is set, VIRT_PHYS_OFFSET is a 64bit variable,
thus __pa() returns as 64bit value.
But when CONFIG_RELOCATABLE=n, __pa() returns 32bit value.

When CONFIG_PHYS_64BIT is set, __pa() should consistently return as
64bit value irrelevant to CONFIG_RELOCATABLE.
So we'd make __pa() consistently return phys_addr_t, which is 64bit
when CONFIG_PHYS_64BIT is set.

Signed-off-by: Bai Yingjie <byj.tea@gmail.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20200106042957.26494-1-yingjie_bai@126.com
arch/powerpc/include/asm/page.h

index 7f1fd41e3065980c2f302a098a633bccc6d597b1..86332080399a57d461c3a0efbd1ac2b3debeb9ab 100644 (file)
@@ -209,7 +209,7 @@ static inline bool pfn_valid(unsigned long pfn)
  */
 #if defined(CONFIG_PPC32) && defined(CONFIG_BOOKE)
 #define __va(x) ((void *)(unsigned long)((phys_addr_t)(x) + VIRT_PHYS_OFFSET))
-#define __pa(x) ((unsigned long)(x) - VIRT_PHYS_OFFSET)
+#define __pa(x) ((phys_addr_t)(unsigned long)(x) - VIRT_PHYS_OFFSET)
 #else
 #ifdef CONFIG_PPC64
 /*