]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
csky: add missing brackets in a macro for tlb.h
authorJason Gunthorpe <jgg@mellanox.com>
Mon, 2 Sep 2019 05:47:05 +0000 (02:47 -0300)
committerJason Gunthorpe <jgg@mellanox.com>
Sat, 7 Sep 2019 07:28:05 +0000 (04:28 -0300)
As an earlier patch made the macro argument more complicated, compilation
now fails with:

 In file included from mm/madvise.c:30:
 mm/madvise.c: In function 'madvise_free_single_vma':
 arch/csky/include/asm/tlb.h:11:11: error:
     invalid type argument of '->' (have 'struct mmu_gather')

Link: https://lore.kernel.org/r/20190901193601.GB5208@mellanox.com
Fixes: 923bfc561e75 ("pagewalk: separate function pointers from iterator data")
Reported-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
arch/csky/include/asm/tlb.h

index 8c7cc097666f04ee5a99b28b606e569ba5fc81ea..fdff9b8d70c811256ce73534c4d32fe5bddda719 100644 (file)
@@ -8,14 +8,14 @@
 
 #define tlb_start_vma(tlb, vma) \
        do { \
-               if (!tlb->fullmm) \
-                       flush_cache_range(vma, vma->vm_start, vma->vm_end); \
+               if (!(tlb)->fullmm) \
+                       flush_cache_range(vma, (vma)->vm_start, (vma)->vm_end); \
        }  while (0)
 
 #define tlb_end_vma(tlb, vma) \
        do { \
-               if (!tlb->fullmm) \
-                       flush_tlb_range(vma, vma->vm_start, vma->vm_end); \
+               if (!(tlb)->fullmm) \
+                       flush_tlb_range(vma, (vma)->vm_start, (vma)->vm_end); \
        }  while (0)
 
 #define tlb_flush(tlb) flush_tlb_mm((tlb)->mm)