]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
staging: unisys: visorbus: keep the success path on the left side
authorDavid Kershner <david.kershner@unisys.com>
Wed, 27 Sep 2017 17:14:35 +0000 (13:14 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 28 Sep 2017 09:17:14 +0000 (11:17 +0200)
If you can't find the dev, it is an error. Indent for the error, instead
of the success.

Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: Tim Sell <timothy.sell@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/unisys/visorbus/visorchipset.c

index 416e74147141a075294208cec43d3b1d27a59d75..80a078128bd14bdc0377f7942e14d86f37c01ac9 100644 (file)
@@ -309,7 +309,6 @@ struct visor_device *visorbus_get_device_by_id(u32 bus_no, u32 dev_no,
 {
        struct device *dev;
        struct device *dev_start = NULL;
-       struct visor_device *vdev = NULL;
        struct visor_busdev id = {
                .bus_no = bus_no,
                .dev_no = dev_no
@@ -319,9 +318,9 @@ struct visor_device *visorbus_get_device_by_id(u32 bus_no, u32 dev_no,
                dev_start = &from->device;
        dev = bus_find_device(&visorbus_type, dev_start, (void *)&id,
                              match_visorbus_dev_by_id);
-       if (dev)
-               vdev = to_visor_device(dev);
-       return vdev;
+       if (!dev)
+               return NULL;
+       return to_visor_device(dev);
 }
 
 static void controlvm_init_response(struct controlvm_message *msg,