]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
media: dvb_usb_pctv452e: module refcount changes were unbalanced
authorWolfgang Rohdewald <wolfgang@rohdewald.de>
Tue, 28 Nov 2017 11:33:52 +0000 (06:33 -0500)
committerMauro Carvalho Chehab <mchehab@s-opensource.com>
Wed, 13 Dec 2017 13:40:47 +0000 (08:40 -0500)
dvb_frontend will call dvb_detach for:
- stb0899_detach in dvb_frontend_release and
- stb0899_release in __dvb_frontend_free

But we only do dvb_attach(stb0899_attach).
Increment the module refcount instead.

Signed-off-by: Wolfgang Rohdewald <wolfgang@rohdewald.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
drivers/media/usb/dvb-usb/pctv452e.c

index 601ade7ca48d176998765b1277b103b5dd411c12..3b7f8298b24dba5fb3b49198097cbcff46b43743 100644 (file)
@@ -913,6 +913,14 @@ static int pctv452e_frontend_attach(struct dvb_usb_adapter *a)
                                                &a->dev->i2c_adap);
        if (!a->fe_adap[0].fe)
                return -ENODEV;
+
+       /*
+        * dvb_frontend will call dvb_detach for both stb0899_detach
+        * and stb0899_release but we only do dvb_attach(stb0899_attach).
+        * Increment the module refcount instead.
+        */
+       symbol_get(stb0899_attach);
+
        if ((dvb_attach(lnbp22_attach, a->fe_adap[0].fe,
                                        &a->dev->i2c_adap)) == NULL)
                err("Cannot attach lnbp22\n");