]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
net: ethernet: pasemi_mac: use phy_ethtool_{get|set}_link_ksettings
authorPhilippe Reynes <tremyfr@gmail.com>
Thu, 14 Jul 2016 21:44:53 +0000 (23:44 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 15 Jul 2016 23:41:34 +0000 (16:41 -0700)
There are two generics functions phy_ethtool_{get|set}_link_ksettings,
so we can use them instead of defining the same code in the driver.

Signed-off-by: Philippe Reynes <tremyfr@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/pasemi/pasemi_mac_ethtool.c

index e99cf4271733b9270b89afaef7b9bc4c0aea0115..d0afc2b8f8e3e9992a7f59a69246fce09764e203 100644 (file)
@@ -62,30 +62,6 @@ static struct {
        { "tx-1024-1518-byte-packets" },
 };
 
-static int
-pasemi_mac_ethtool_get_settings(struct net_device *netdev,
-                              struct ethtool_cmd *cmd)
-{
-       struct phy_device *phydev = netdev->phydev;
-
-       if (!phydev)
-               return -EOPNOTSUPP;
-
-       return phy_ethtool_gset(phydev, cmd);
-}
-
-static int
-pasemi_mac_ethtool_set_settings(struct net_device *netdev,
-                              struct ethtool_cmd *cmd)
-{
-       struct phy_device *phydev = netdev->phydev;
-
-       if (!phydev)
-               return -EOPNOTSUPP;
-
-       return phy_ethtool_sset(phydev, cmd);
-}
-
 static u32
 pasemi_mac_ethtool_get_msglevel(struct net_device *netdev)
 {
@@ -143,8 +119,6 @@ static void pasemi_mac_get_strings(struct net_device *netdev, u32 stringset,
 }
 
 const struct ethtool_ops pasemi_mac_ethtool_ops = {
-       .get_settings           = pasemi_mac_ethtool_get_settings,
-       .set_settings           = pasemi_mac_ethtool_set_settings,
        .get_msglevel           = pasemi_mac_ethtool_get_msglevel,
        .set_msglevel           = pasemi_mac_ethtool_set_msglevel,
        .get_link               = ethtool_op_get_link,
@@ -152,5 +126,7 @@ const struct ethtool_ops pasemi_mac_ethtool_ops = {
        .get_strings            = pasemi_mac_get_strings,
        .get_sset_count         = pasemi_mac_get_sset_count,
        .get_ethtool_stats      = pasemi_mac_get_ethtool_stats,
+       .get_link_ksettings     = phy_ethtool_get_link_ksettings,
+       .set_link_ksettings     = phy_ethtool_set_link_ksettings,
 };