]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
staging: ks7010: factor out initial enqueue process into ks7010_sme_enqueue_events
authorSergio Paracuellos <sergio.paracuellos@gmail.com>
Tue, 3 Apr 2018 15:12:59 +0000 (17:12 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 23 Apr 2018 12:22:07 +0000 (14:22 +0200)
This commit extract initial enqueue process into a new
ks7010_sme_enqueue_events function.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/ks7010/ks7010_sdio.c

index 9af79ac32b1bb7d3acd09f93b25984045eebb87b..9907c0cec95861a8081485e59409fc5bd697daf8 100644 (file)
@@ -730,21 +730,8 @@ static int ks7010_upload_firmware(struct ks_sdio_card *card)
        return ret;
 }
 
-static void ks7010_card_init(struct ks_wlan_private *priv)
+static void ks7010_sme_enqueue_events(struct ks_wlan_private *priv)
 {
-       init_completion(&priv->confirm_wait);
-
-       /* get mac address & firmware version */
-       hostif_sme_enqueue(priv, SME_START);
-
-       if (!wait_for_completion_interruptible_timeout
-           (&priv->confirm_wait, 5 * HZ)) {
-               netdev_dbg(priv->net_dev, "wait time out!! SME_START\n");
-       }
-
-       if (priv->mac_address_valid && priv->version_size != 0)
-               priv->dev_state = DEVICE_STATE_PREINIT;
-
        hostif_sme_enqueue(priv, SME_GET_EEPROM_CKSUM);
 
        /* load initial wireless parameter */
@@ -763,6 +750,24 @@ static void ks7010_card_init(struct ks_wlan_private *priv)
        hostif_sme_enqueue(priv, SME_RSN_ENABLED_REQUEST);
        hostif_sme_enqueue(priv, SME_MODE_SET_REQUEST);
        hostif_sme_enqueue(priv, SME_START_REQUEST);
+}
+
+static void ks7010_card_init(struct ks_wlan_private *priv)
+{
+       init_completion(&priv->confirm_wait);
+
+       /* get mac address & firmware version */
+       hostif_sme_enqueue(priv, SME_START);
+
+       if (!wait_for_completion_interruptible_timeout
+           (&priv->confirm_wait, 5 * HZ)) {
+               netdev_dbg(priv->net_dev, "wait time out!! SME_START\n");
+       }
+
+       if (priv->mac_address_valid && priv->version_size != 0)
+               priv->dev_state = DEVICE_STATE_PREINIT;
+
+       ks7010_sme_enqueue_events(priv);
 
        if (!wait_for_completion_interruptible_timeout
            (&priv->confirm_wait, 5 * HZ)) {