rcu: Convert ->need_future_gp[] array to boolean

There is no longer any need for ->need_future_gp[] to count the number of
requests for future grace periods, so this commit converts the additions
to assignments to "true" and reduces the size of each element to one byte.
While we are in the area, fix an obsolete comment.

Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Tested-by: Nicholas Piggin <npiggin@gmail.com>

diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
index b05ab63795621b1fdfb1d180d08ea446d6f04f3b..6ef1f2b4a6d3e6d71c332e94e5978fa9dabcd0f1 100644 (file)
--- a/kernel/rcu/tree.c
+++ b/kernel/rcu/tree.c
@@ -1709,7 +1709,7 @@ rcu_start_future_gp(struct rcu_node *rnp, struct rcu_data *rdp,
         * current grace period, we don't need to explicitly start one.
         */
        if (rnp->gpnum != rnp->completed) {
-               need_future_gp_element(rnp, c)++;
+               need_future_gp_element(rnp, c) = true;
                trace_rcu_future_gp(rnp, rdp, c, TPS("Startedleaf"));
                goto out;
        }
@@ -1741,7 +1741,7 @@ rcu_start_future_gp(struct rcu_node *rnp, struct rcu_data *rdp,
        }
 
        /* Record the need for the future grace period. */
-       need_future_gp_element(rnp_root, c)++;
+       need_future_gp_element(rnp_root, c) = true;
 
        /* If a grace period is not already in progress, start one. */
        if (rnp_root->gpnum != rnp_root->completed) {
@@ -1769,7 +1769,7 @@ static bool rcu_future_gp_cleanup(struct rcu_state *rsp, struct rcu_node *rnp)
        bool needmore;
        struct rcu_data *rdp = this_cpu_ptr(rsp->rda);
 
-       need_future_gp_element(rnp, c) = 0;
+       need_future_gp_element(rnp, c) = false;
        needmore = need_any_future_gp(rnp);
        trace_rcu_future_gp(rnp, rdp, c,
                            needmore ? TPS("CleanupMore") : TPS("Cleanup"));

diff --git a/kernel/rcu/tree.h b/kernel/rcu/tree.h
index 123c30eac8b5b42323cf8ef32b7e5167bd655729..9f97fd7f648c7b0686bce5818089863146ea2447 100644 (file)
--- a/kernel/rcu/tree.h
+++ b/kernel/rcu/tree.h
@@ -150,7 +150,7 @@ struct rcu_node {
        struct swait_queue_head nocb_gp_wq[2];
                                /* Place for rcu_nocb_kthread() to wait GP. */
 #endif /* #ifdef CONFIG_RCU_NOCB_CPU */
-       int need_future_gp[4];  /* Counts of upcoming no-CB GP requests. */
+       u8 need_future_gp[4];   /* Counts of upcoming GP requests. */
        raw_spinlock_t fqslock ____cacheline_internodealigned_in_smp;
 
        spinlock_t exp_lock ____cacheline_internodealigned_in_smp;