]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
scsi: mptfusion: use strlcpy() instead of strncpy()
authorXiongfeng Wang <xiongfeng.wang@linaro.org>
Mon, 8 Jan 2018 12:49:13 +0000 (20:49 +0800)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 9 Jan 2018 02:53:56 +0000 (21:53 -0500)
gcc-8 reports

drivers/message/fusion/mptbase.c: In function 'mpt_display_event_info':
./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified
bound 100 equals destination size [-Wstringop-truncation]

We need to use strlcpy() to make sure the dest string is nul-terminated.

Signed-off-by: Xiongfeng Wang <xiongfeng.wang@linaro.org>
Reviewed-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/message/fusion/mptbase.c

index 8df37fa1e97777c9f4eff25e998f1729ff449e05..51eb1b0279638cd00f8117ad8ac739d21d422658 100644 (file)
@@ -7698,7 +7698,7 @@ mpt_display_event_info(MPT_ADAPTER *ioc, EventNotificationReply_t *pEventReply)
                break;
        }
        if (ds)
-               strncpy(evStr, ds, EVENT_DESCR_STR_SZ);
+               strlcpy(evStr, ds, EVENT_DESCR_STR_SZ);
 
 
        devtprintk(ioc, printk(MYIOC_s_DEBUG_FMT