]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
net: hns3: use macro instead of magic number
authorHuazhong Tan <tanhuazhong@huawei.com>
Wed, 28 Aug 2019 14:23:06 +0000 (22:23 +0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 29 Aug 2019 23:57:43 +0000 (16:57 -0700)
This patch uses macro to replace some magic number.

Signed-off-by: Huazhong Tan <tanhuazhong@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.c
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.h

index a56f3888aba2405bdeded7b83ab42a152999c7fc..3b4cd23cbda34f9618a299d86477404b36b596da 100644 (file)
@@ -774,7 +774,8 @@ static void hclge_dbg_dump_qos_buf_cfg(struct hclge_dev *hdev)
        rx_priv_wl = (struct hclge_rx_priv_wl_buf *)desc[1].data;
        for (i = 0; i < HCLGE_TC_NUM_ONE_DESC; i++)
                dev_info(&hdev->pdev->dev,
-                        "rx_priv_wl_tc_%d: high: 0x%x, low: 0x%x\n", i + 4,
+                        "rx_priv_wl_tc_%d: high: 0x%x, low: 0x%x\n",
+                        i + HCLGE_TC_NUM_ONE_DESC,
                         rx_priv_wl->tc_wl[i].high, rx_priv_wl->tc_wl[i].low);
 
        cmd = HCLGE_OPC_RX_COM_THRD_ALLOC;
@@ -796,7 +797,8 @@ static void hclge_dbg_dump_qos_buf_cfg(struct hclge_dev *hdev)
        rx_com_thrd = (struct hclge_rx_com_thrd *)desc[1].data;
        for (i = 0; i < HCLGE_TC_NUM_ONE_DESC; i++)
                dev_info(&hdev->pdev->dev,
-                        "rx_com_thrd_tc_%d: high: 0x%x, low: 0x%x\n", i + 4,
+                        "rx_com_thrd_tc_%d: high: 0x%x, low: 0x%x\n",
+                        i + HCLGE_TC_NUM_ONE_DESC,
                         rx_com_thrd->com_thrd[i].high,
                         rx_com_thrd->com_thrd[i].low);
        return;
index 80e5cc29fc20c9797b623bc69f4ec21511a5e0e4..38b79321c4c44057774d49996c861fb3ec210557 100644 (file)
@@ -72,9 +72,10 @@ struct hclge_dbg_reg_common_msg {
        enum hclge_opcode_type cmd;
 };
 
+#define        HCLGE_DBG_MAX_DFX_MSG_LEN       60
 struct hclge_dbg_dfx_message {
        int flag;
-       char message[60];
+       char message[HCLGE_DBG_MAX_DFX_MSG_LEN];
 };
 
 #define HCLGE_DBG_MAC_REG_TYPE_LEN     32