]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
watchdog: menf21bmc: add I2C dependency
authorArnd Bergmann <arnd@arndb.de>
Tue, 28 Feb 2017 21:01:20 +0000 (22:01 +0100)
committerGuenter Roeck <linux@roeck-us.net>
Wed, 1 Mar 2017 14:15:10 +0000 (06:15 -0800)
This driver fails to link when CONFIG_I2C is disabled or a loadable module while
the watchdog is built-in:

drivers/watchdog/built-in.o: In function `menf21bmc_wdt_shutdown':
menf21bmc_wdt.c:(.text+0x9b44): undefined reference to `i2c_smbus_write_word_data'
menf21bmc_wdt.c:(.text+0x9b44): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `i2c_smbus_write_word_data'

This adds a Kconfig dependency for it, to enforce a valid configuration.

Fixes: da2a68b3eb47 ("watchdog: Enable COMPILE_TEST where possible")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
drivers/watchdog/Kconfig

index 5b4bb1b6dd68e03ed64e1b727a5930951811ae6d..4d2c336daa394c01e7b1f1a1b04b7efef9a04ad8 100644 (file)
@@ -142,6 +142,7 @@ config GPIO_WATCHDOG_ARCH_INITCALL
 config MENF21BMC_WATCHDOG
        tristate "MEN 14F021P00 BMC Watchdog"
        depends on MFD_MENF21BMC || COMPILE_TEST
+       depends on I2C
        select WATCHDOG_CORE
        help
          Say Y here to include support for the MEN 14F021P00 BMC Watchdog.