drm/i915/sdvo: Don't unpack stack garbage

Pass the length returned by intel_sdvo_read_infoframe() to
hdmi_infoframe_unpack() so that we don't try to unpack any
leftover stack garbage.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190409144054.24561-6-ville.syrjala@linux.intel.com
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>

diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c
index bc1ef161df32fb4715944f558f2d289160e9c22c..1c8ad680813c2786f9fa81c76f0eb0144291cc32 100644 (file)
--- a/drivers/gpu/drm/i915/intel_sdvo.c
+++ b/drivers/gpu/drm/i915/intel_sdvo.c
@@ -1132,7 +1132,7 @@ static void intel_sdvo_get_avi_infoframe(struct intel_sdvo *intel_sdvo,
        crtc_state->infoframes.enable |=
                intel_hdmi_infoframe_enable(HDMI_INFOFRAME_TYPE_AVI);
 
-       ret = hdmi_infoframe_unpack(frame, sdvo_data, sizeof(sdvo_data));
+       ret = hdmi_infoframe_unpack(frame, sdvo_data, len);
        if (ret) {
                DRM_DEBUG_KMS("Failed to unpack AVI infoframe\n");
                return;