]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
video: fbdev: au1200fb: Fix incorrect IRQ freeing
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Thu, 9 Nov 2017 17:09:29 +0000 (18:09 +0100)
committerBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Thu, 9 Nov 2017 17:09:29 +0000 (18:09 +0100)
'au1200fb_drv_probe()' can not fail after a successful call to
'request_irq()'. So there is no point to call 'free_irq()' in the error
handling path.

Moreover, the hard coded AU1200_LCD_INT looks boggus since
commit 1630d85a8312 ("au1200fb: fix hardcoded IRQ").

So, remove it.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: Tejun Heo <tj@kernel.org>
[b.zolnierkie: patch summary and description fixups]
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
drivers/video/fbdev/au1200fb.c

index cf54168d44dc7b579177580f824cb015e32646b7..0d8ed0ef9183952a647330bf7358e7dda57b157a 100644 (file)
@@ -1766,8 +1766,6 @@ static int au1200fb_drv_probe(struct platform_device *dev)
                        fb_dealloc_cmap(&fbi->cmap);
                kfree(fbi->pseudo_palette);
        }
-       if (plane == 0)
-               free_irq(AU1200_LCD_INT, (void*)dev);
        return ret;
 }