]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
gpio: max77620: Do not allocate IRQs upfront
authorThierry Reding <treding@nvidia.com>
Wed, 2 Oct 2019 12:28:24 +0000 (14:28 +0200)
committerLinus Walleij <linus.walleij@linaro.org>
Fri, 4 Oct 2019 21:59:44 +0000 (23:59 +0200)
regmap_add_irq_chip() will try to allocate all of the IRQ descriptors
upfront if passed a non-zero irq_base parameter. However, the intention
is to allocate IRQ descriptors on an as-needed basis if possible. Pass 0
instead of -1 to fix that use-case.

Signed-off-by: Thierry Reding <treding@nvidia.com>
Link: https://lore.kernel.org/r/20191002122825.3948322-2-thierry.reding@gmail.com
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
drivers/gpio/gpio-max77620.c

index 47d05e357e61a05b742fd75d892fa3d3e5506af0..3094fad151b437be67d000709ead274dcd114ef6 100644 (file)
@@ -304,7 +304,7 @@ static int max77620_gpio_probe(struct platform_device *pdev)
        }
 
        ret = devm_regmap_add_irq_chip(&pdev->dev, chip->rmap, gpio_irq,
-                                      IRQF_ONESHOT, -1,
+                                      IRQF_ONESHOT, 0,
                                       &max77620_gpio_irq_chip,
                                       &chip->gpio_irq_data);
        if (ret < 0) {