]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
btrfs: sysfs: add removal calls for debug/
authorDennis Zhou <dennis@kernel.org>
Sat, 14 Dec 2019 00:22:17 +0000 (16:22 -0800)
committerDavid Sterba <dsterba@suse.com>
Mon, 20 Jan 2020 15:40:58 +0000 (16:40 +0100)
We probably should call sysfs_remove_group() on debug/.

Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: Anand Jain <anand.jain@oracle.com>
Signed-off-by: Dennis Zhou <dennis@kernel.org>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/sysfs.c

index 16379f491ca1db5523eac50c32cf23faafc33b11..4c022757ffa43e79b66cd7a744225105ed966185 100644 (file)
@@ -771,6 +771,10 @@ void btrfs_sysfs_remove_mounted(struct btrfs_fs_info *fs_info)
                kobject_del(fs_info->space_info_kobj);
                kobject_put(fs_info->space_info_kobj);
        }
+#ifdef CONFIG_BTRFS_DEBUG
+       sysfs_remove_group(&fs_info->fs_devices->fsid_kobj,
+                          &btrfs_debug_feature_attr_group);
+#endif
        addrm_unknown_feature_attrs(fs_info, false);
        sysfs_remove_group(&fs_info->fs_devices->fsid_kobj, &btrfs_feature_attr_group);
        sysfs_remove_files(&fs_info->fs_devices->fsid_kobj, btrfs_attrs);
@@ -1205,6 +1209,9 @@ void __cold btrfs_exit_sysfs(void)
        sysfs_unmerge_group(&btrfs_kset->kobj,
                            &btrfs_static_feature_attr_group);
        sysfs_remove_group(&btrfs_kset->kobj, &btrfs_feature_attr_group);
+#ifdef CONFIG_BTRFS_DEBUG
+       sysfs_remove_group(&btrfs_kset->kobj, &btrfs_debug_feature_attr_group);
+#endif
        kset_unregister(btrfs_kset);
 }