ARM: versatile: fix a leaked reference by addingmissing of_node_put

The call to of_get_next_child returns a node pointer with refcount
incremented thus it must be explicitly decremented after the last
usage.

Detected by coccinelle with the following warnings:
./arch/arm/mach-versatile/versatile_dt.c:315:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 302, but without a corresponding object release within this function.
./arch/arm/mach-versatile/versatile_dt.c:320:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 302, but without a corresponding object release within this function.

Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Russell King <linux@armlinux.org.uk>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

diff --git a/arch/arm/mach-versatile/versatile_dt.c b/arch/arm/mach-versatile/versatile_dt.c
index e9d60687e416a24edc195d32030631e2a0a7c9fb..028463af726d4819d01d5a41d440d18db824c05c 100644 (file)
--- a/arch/arm/mach-versatile/versatile_dt.c
+++ b/arch/arm/mach-versatile/versatile_dt.c
@@ -312,12 +312,12 @@ static void __init versatile_dt_pci_init(void)
                 * driver had it so we will keep it.
                 */
                writel(1, versatile_sys_base + VERSATILE_SYS_PCICTL_OFFSET);
-               return;
+               goto out_put_node;
        }
 
        newprop = kzalloc(sizeof(*newprop), GFP_KERNEL);
        if (!newprop)
-               return;
+               goto out_put_node;
 
        newprop->name = kstrdup("status", GFP_KERNEL);
        newprop->value = kstrdup("disabled", GFP_KERNEL);
@@ -325,6 +325,9 @@ static void __init versatile_dt_pci_init(void)
        of_update_property(np, newprop);
 
        pr_info("Not plugged into PCI backplane!\n");
+
+out_put_node:
+       of_node_put(np);
 }
 
 static void __init versatile_dt_init(void)