]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
net: qualcomm: rmnet: Remove redundant command check
authorSubash Abhinov Kasiviswanathan <subashab@codeaurora.org>
Wed, 16 May 2018 00:52:02 +0000 (18:52 -0600)
committerDavid S. Miller <davem@davemloft.net>
Wed, 16 May 2018 18:23:04 +0000 (14:23 -0400)
The command packet size is already checked once in
rmnet_map_deaggregate() for the header, packet and trailer size, so
this additional check is not needed.

Signed-off-by: Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/qualcomm/rmnet/rmnet_map_command.c

index 78fdad0c6f76b1358906f99f095cd9abb2a27562..56a93df962e6a66c83653e720b4c4571679fdb73 100644 (file)
@@ -69,17 +69,9 @@ static void rmnet_map_send_ack(struct sk_buff *skb,
        struct rmnet_map_control_command *cmd;
        int xmit_status;
 
-       if (port->data_format & RMNET_FLAGS_INGRESS_MAP_CKSUMV4) {
-               if (skb->len < sizeof(struct rmnet_map_header) +
-                   RMNET_MAP_GET_LENGTH(skb) +
-                   sizeof(struct rmnet_map_dl_csum_trailer)) {
-                       kfree_skb(skb);
-                       return;
-               }
-
-               skb_trim(skb, skb->len -
-                        sizeof(struct rmnet_map_dl_csum_trailer));
-       }
+       if (port->data_format & RMNET_FLAGS_INGRESS_MAP_CKSUMV4)
+               skb_trim(skb,
+                        skb->len - sizeof(struct rmnet_map_dl_csum_trailer));
 
        skb->protocol = htons(ETH_P_MAP);