]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
rtc: tx4939: remove useless test
authorAlexandre Belloni <alexandre.belloni@bootlin.com>
Sun, 3 Mar 2019 21:54:49 +0000 (22:54 +0100)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Sun, 3 Mar 2019 21:54:49 +0000 (22:54 +0100)
The tested condition will never happen as the core always passes a fully
set struct tm (using rtc_ktime_to_tm) to the .set_alarm callback.

Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-tx4939.c

index 61c110b2045f836dbfffb54563e8d7057fae3cc1..8497fceea27f59c014e15b2c3ccc7274ddc53da0 100644 (file)
@@ -123,13 +123,6 @@ static int tx4939_rtc_set_alarm(struct device *dev, struct rtc_wkalrm *alrm)
        unsigned long sec;
        unsigned char buf[6];
 
-       if (alrm->time.tm_sec < 0 ||
-           alrm->time.tm_min < 0 ||
-           alrm->time.tm_hour < 0 ||
-           alrm->time.tm_mday < 0 ||
-           alrm->time.tm_mon < 0 ||
-           alrm->time.tm_year < 0)
-               return -EINVAL;
        rtc_tm_to_time(&alrm->time, &sec);
        buf[0] = 0;
        buf[1] = 0;