]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
drm: Do not call drm_dp_cec_set_edid() while registering DP connectors
authorJosé Roberto de Souza <jose.souza@intel.com>
Thu, 11 Oct 2018 00:44:39 +0000 (17:44 -0700)
committerDaniel Vetter <daniel.vetter@ffwll.ch>
Thu, 11 Oct 2018 08:52:35 +0000 (10:52 +0200)
drm_dp_cec_register_connector() is called when registering each DP
connector in DRM, while sounds a good idea register CEC adapters as
earlier as possible, it causes some driver initialization delay
trying to do DPCD transactions in disconnected connectors.

This change will cause no regressions as drm_dp_cec_set_edid() will
still be called in further detection of connected connectors with a
valid edid parameter.

This change reduced the module load of i915 by average 0.5sec in a
machine with just one DP port disconnected while reducing more than
3sec in a machine with 4 DP ports disconnected.

Cc: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/20181011004439.4482-1-jose.souza@intel.com
drivers/gpu/drm/drm_dp_cec.c

index 8a718f85079a0d55d10e41f3d9e907a090adbbda..b15cee85b702b257f0ebdd19c3d2f6e4995207fc 100644 (file)
@@ -424,8 +424,6 @@ void drm_dp_cec_register_connector(struct drm_dp_aux *aux, const char *name,
        aux->cec.parent = parent;
        INIT_DELAYED_WORK(&aux->cec.unregister_work,
                          drm_dp_cec_unregister_work);
-
-       drm_dp_cec_set_edid(aux, NULL);
 }
 EXPORT_SYMBOL(drm_dp_cec_register_connector);