]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
btrfs: return the actual error value from from btrfs_uuid_tree_iterate
authorPan Bian <bianpan2016@163.com>
Sun, 4 Dec 2016 04:51:53 +0000 (12:51 +0800)
committerDavid Sterba <dsterba@suse.com>
Mon, 19 Dec 2016 17:08:15 +0000 (18:08 +0100)
In function btrfs_uuid_tree_iterate(), errno is assigned to variable ret
on errors. However, it directly returns 0. It may be better to return
ret. This patch also removes the warning, because the caller already
prints a warning.

Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=188731
Signed-off-by: Pan Bian <bianpan2016@163.com>
Reviewed-by: Omar Sandoval <osandov@fb.com>
[ edited subject ]
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/uuid-tree.c

index 161342b73ce50256bd2cba63b0d1c5ece503f599..726f928238d0c86a931cd58613799e59cc35fdf8 100644 (file)
@@ -352,7 +352,5 @@ int btrfs_uuid_tree_iterate(struct btrfs_fs_info *fs_info,
 
 out:
        btrfs_free_path(path);
-       if (ret)
-               btrfs_warn(fs_info, "btrfs_uuid_tree_iterate failed %d", ret);
-       return 0;
+       return ret;
 }