]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
Staging: gasket: Use DIV_ROUND_UP
authorMadhumitha Prabakaran <madhumithabiw@gmail.com>
Wed, 3 Apr 2019 15:06:43 +0000 (10:06 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 16 Apr 2019 11:22:50 +0000 (13:22 +0200)
Use DIV_ROUND_UP in-kernel function to make code simple and more
understandable.

Issue found using Coccinelle.

Signed-off-by: Madhumitha Prabakaran <madhumithabiw@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/gasket/gasket_page_table.c

index 26755d9ca41dff9cc164cb8684aa6772ec3f394a..600928f635777e518737e16688e5ddf25ba274f9 100644 (file)
@@ -768,8 +768,7 @@ static bool gasket_is_extended_dev_addr_bad(struct gasket_page_table *pg_tbl,
        page_lvl0_idx = gasket_extended_lvl0_page_idx(pg_tbl, dev_addr);
 
        /* Get the count of affected level 0 pages. */
-       num_lvl0_pages = (num_pages + GASKET_PAGES_PER_SUBTABLE - 1) /
-               GASKET_PAGES_PER_SUBTABLE;
+       num_lvl0_pages = DIV_ROUND_UP(num_pages, GASKET_PAGES_PER_SUBTABLE);
 
        if (gasket_components_to_dev_address(pg_tbl, 0, page_global_idx,
                                             page_offset) != dev_addr) {
@@ -1258,7 +1257,7 @@ int gasket_alloc_coherent_memory(struct gasket_dev *gasket_dev, u64 size,
        dma_addr_t handle;
        void *mem;
        int j;
-       unsigned int num_pages = (size + PAGE_SIZE - 1) / PAGE_SIZE;
+       unsigned int num_pages = DIV_ROUND_UP(size, PAGE_SIZE);
        const struct gasket_driver_desc *driver_desc =
                gasket_get_driver_desc(gasket_dev);