]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
ipv6: exthdrs: use swap macro in ipv6_dest_hao
authorGustavo A. R. Silva <garsilva@embeddedor.com>
Fri, 27 Oct 2017 04:10:35 +0000 (23:10 -0500)
committerDavid S. Miller <davem@davemloft.net>
Sat, 28 Oct 2017 10:06:59 +0000 (19:06 +0900)
make use of the swap macro and remove unnecessary variable tmp_addr.
This makes the code easier to read and maintain.

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/ipv6/exthdrs.c

index 7835dea930b4522befb24cd287a562d5d37642f0..9f918a770f87795467c9f9ea279acb0de52364e7 100644 (file)
@@ -187,7 +187,6 @@ static bool ipv6_dest_hao(struct sk_buff *skb, int optoff)
        struct ipv6_destopt_hao *hao;
        struct inet6_skb_parm *opt = IP6CB(skb);
        struct ipv6hdr *ipv6h = ipv6_hdr(skb);
-       struct in6_addr tmp_addr;
        int ret;
 
        if (opt->dsthao) {
@@ -229,9 +228,7 @@ static bool ipv6_dest_hao(struct sk_buff *skb, int optoff)
        if (skb->ip_summed == CHECKSUM_COMPLETE)
                skb->ip_summed = CHECKSUM_NONE;
 
-       tmp_addr = ipv6h->saddr;
-       ipv6h->saddr = hao->addr;
-       hao->addr = tmp_addr;
+       swap(ipv6h->saddr, hao->addr);
 
        if (skb->tstamp == 0)
                __net_timestamp(skb);