]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
pd: don't check blk_execute_rq return value.
authorChristoph Hellwig <hch@lst.de>
Thu, 20 Apr 2017 14:02:54 +0000 (16:02 +0200)
committerJens Axboe <axboe@fb.com>
Thu, 20 Apr 2017 18:16:10 +0000 (12:16 -0600)
The driver never sets req->errors, so blk_execute_rq will always return 0.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Bart Van Assche <Bart.VanAssche@sandisk.com>
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
Signed-off-by: Jens Axboe <axboe@fb.com>
drivers/block/paride/pd.c

index b05e151c9b38eb7bb7fe54b3a82d5a8f3cdf51c7..7d2402f9097892332a43ba632c88084f52b53efa 100644 (file)
@@ -739,18 +739,15 @@ static int pd_special_command(struct pd_unit *disk,
                      enum action (*func)(struct pd_unit *disk))
 {
        struct request *rq;
-       int err = 0;
 
        rq = blk_get_request(disk->gd->queue, REQ_OP_DRV_IN, __GFP_RECLAIM);
        if (IS_ERR(rq))
                return PTR_ERR(rq);
 
        rq->special = func;
-
-       err = blk_execute_rq(disk->gd->queue, disk->gd, rq, 0);
-
+       blk_execute_rq(disk->gd->queue, disk->gd, rq, 0);
        blk_put_request(rq);
-       return err;
+       return 0;
 }
 
 /* kernel glue structures */