]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
staging: iio: adt7316: Fix build errors when GPIOLIB is not set
authorFabio Estevam <festevam@gmail.com>
Thu, 6 Jun 2019 02:05:32 +0000 (23:05 -0300)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Sat, 8 Jun 2019 11:54:47 +0000 (12:54 +0100)
On x86_64 when GPIOLIB is not set the following build errors
are seen:

drivers/staging/iio/addac/adt7316.c:947:3: error: implicit declaration of function 'gpiod_set_value' [-Werror=implicit-function-declaration]
drivers/staging/iio/addac/adt7316.c:1805:2: error: implicit declaration of function 'irqd_get_trigger_type' [-Werror=implicit-function-declaration]

These functions are provided by the <linux/gpio/consumer.h>
and <linux/irq.h> headers, so include them to fix these
build errors.

While at it, remove <linux/gpio.h> as this driver is a GPIO
consumer and not a GPIO driver.

Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Fabio Estevam <festevam@gmail.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/staging/iio/addac/adt7316.c

index b6a65ee8d558e633cc85a012110f352ad6978eb2..dc8c25ddb97e7c6b70d064bdb3517c82e9718b38 100644 (file)
@@ -6,7 +6,8 @@
  */
 
 #include <linux/interrupt.h>
-#include <linux/gpio.h>
+#include <linux/gpio/consumer.h>
+#include <linux/irq.h>
 #include <linux/workqueue.h>
 #include <linux/device.h>
 #include <linux/kernel.h>