]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
net: dsa: mv88e6xxx: Fix IRQ when loading module
authorAndrew Lunn <andrew@lunn.ch>
Sat, 17 Mar 2018 19:21:09 +0000 (20:21 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sun, 18 Mar 2018 00:24:48 +0000 (20:24 -0400)
Handle polled interrupts correctly when loading the module.

Signed-off-by: Andrew Lunn <andrew@lunn.ch>
Fixes: 294d711ee8c0 ("net: dsa: mv88e6xxx: Poll when no interrupt defined")
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dsa/mv88e6xxx/chip.c

index bd3ee84770c750ea289af014550071a0a8475e52..41f872d4ba3c0e97e8eb5e33cc7203317973bb24 100644 (file)
@@ -4204,15 +4204,18 @@ static void mv88e6xxx_remove(struct mdio_device *mdiodev)
        mv88e6xxx_unregister_switch(chip);
        mv88e6xxx_mdios_unregister(chip);
 
-       if (chip->irq > 0) {
-               mv88e6xxx_g1_vtu_prob_irq_free(chip);
-               mv88e6xxx_g1_atu_prob_irq_free(chip);
-               if (chip->info->g2_irqs > 0)
-                       mv88e6xxx_g2_irq_free(chip);
-               mutex_lock(&chip->reg_lock);
+       mv88e6xxx_g1_vtu_prob_irq_free(chip);
+       mv88e6xxx_g1_atu_prob_irq_free(chip);
+
+       if (chip->info->g2_irqs > 0)
+               mv88e6xxx_g2_irq_free(chip);
+
+       mutex_lock(&chip->reg_lock);
+       if (chip->irq > 0)
                mv88e6xxx_g1_irq_free(chip);
-               mutex_unlock(&chip->reg_lock);
-       }
+       else
+               mv88e6xxx_irq_poll_free(chip);
+       mutex_unlock(&chip->reg_lock);
 }
 
 static const struct of_device_id mv88e6xxx_of_match[] = {