]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
drm/amdgpu: use REG32_PCIE wrapper instead for psp
authorHuang Rui <ray.huang@amd.com>
Mon, 25 Feb 2019 07:02:44 +0000 (15:02 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 28 Feb 2019 03:18:59 +0000 (22:18 -0500)
This patch uses REG32_PCIE wrapper instead of writting pci_index2 and reading
pci_data2 for psp. This sequence should be protected by pcie_idx_lock.

Signed-off-by: Huang Rui <ray.huang@amd.com>
Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/amdgpu/psp_v3_1.c

index c63de945c0214d6321da38c7a70a60f52561c5b1..0487e3a4e9e783c603e54720304e89e260c5c440 100644 (file)
@@ -500,9 +500,7 @@ static bool psp_v3_1_smu_reload_quirk(struct psp_context *psp)
        struct amdgpu_device *adev = psp->adev;
        uint32_t reg;
 
-       reg = smnMP1_FIRMWARE_FLAGS | 0x03b00000;
-       WREG32_SOC15(NBIO, 0, mmPCIE_INDEX2, reg);
-       reg = RREG32_SOC15(NBIO, 0, mmPCIE_DATA2);
+       reg = RREG32_PCIE(smnMP1_FIRMWARE_FLAGS | 0x03b00000);
        return (reg & MP1_FIRMWARE_FLAGS__INTERRUPTS_ENABLED_MASK) ? true : false;
 }