]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
net: devlink: don't pass return value of __devlink_port_type_set()
authorJiri Pirko <jiri@mellanox.com>
Sun, 24 Mar 2019 10:14:30 +0000 (11:14 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sun, 24 Mar 2019 18:55:31 +0000 (14:55 -0400)
__devlink_port_type_set() returns void, it makes no sense to pass it on,
so don't do that.

Signed-off-by: Jiri Pirko <jiri@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/core/devlink.c

index 65c1cf4a5764ea1cd6962d3e2f9ca8162bb1f421..418efeafa79bfbe818bc88640a27a7bd7eafa08b 100644 (file)
@@ -5342,8 +5342,7 @@ static void __devlink_port_type_set(struct devlink_port *devlink_port,
 void devlink_port_type_eth_set(struct devlink_port *devlink_port,
                               struct net_device *netdev)
 {
-       return __devlink_port_type_set(devlink_port,
-                                      DEVLINK_PORT_TYPE_ETH, netdev);
+       __devlink_port_type_set(devlink_port, DEVLINK_PORT_TYPE_ETH, netdev);
 }
 EXPORT_SYMBOL_GPL(devlink_port_type_eth_set);
 
@@ -5356,8 +5355,7 @@ EXPORT_SYMBOL_GPL(devlink_port_type_eth_set);
 void devlink_port_type_ib_set(struct devlink_port *devlink_port,
                              struct ib_device *ibdev)
 {
-       return __devlink_port_type_set(devlink_port,
-                                      DEVLINK_PORT_TYPE_IB, ibdev);
+       __devlink_port_type_set(devlink_port, DEVLINK_PORT_TYPE_IB, ibdev);
 }
 EXPORT_SYMBOL_GPL(devlink_port_type_ib_set);
 
@@ -5368,8 +5366,7 @@ EXPORT_SYMBOL_GPL(devlink_port_type_ib_set);
  */
 void devlink_port_type_clear(struct devlink_port *devlink_port)
 {
-       return __devlink_port_type_set(devlink_port,
-                                      DEVLINK_PORT_TYPE_NOTSET, NULL);
+       __devlink_port_type_set(devlink_port, DEVLINK_PORT_TYPE_NOTSET, NULL);
 }
 EXPORT_SYMBOL_GPL(devlink_port_type_clear);