]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
i2c: busses: remove superfluous ignoring of children for RPM
authorWolfram Sang <wsa+renesas@sang-engineering.com>
Sun, 29 Apr 2018 18:41:04 +0000 (20:41 +0200)
committerWolfram Sang <wsa@the-dreams.de>
Tue, 8 May 2018 21:19:02 +0000 (23:19 +0200)
These days, the I2C core ensures that the embedded adapter device
ignores the PM states of its children already. Because the adapter
device is an opaque logical device, there is no need for drivers to
repeat that again.

Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
drivers/i2c/busses/i2c-hix5hd2.c
drivers/i2c/busses/i2c-nomadik.c
drivers/i2c/busses/i2c-sh_mobile.c

index bb68957d3da5e6846169ae1b26bfd37f9e6d1caa..1504c3c1a1c06c0aa1558c99bd09bf139af1d124 100644 (file)
@@ -471,7 +471,6 @@ static int hix5hd2_i2c_probe(struct platform_device *pdev)
                goto err_clk;
        }
 
-       pm_suspend_ignore_children(&pdev->dev, true);
        pm_runtime_set_autosuspend_delay(priv->dev, MSEC_PER_SEC);
        pm_runtime_use_autosuspend(priv->dev);
        pm_runtime_set_active(priv->dev);
index 49c7c0c91486a48321b7711c04166b13dda97001..0ed5a41804dcf8d5d33d043a3d0f8e29b5430e4f 100644 (file)
@@ -1012,8 +1012,6 @@ static int nmk_i2c_probe(struct amba_device *adev, const struct amba_id *id)
                goto err_no_mem;
        }
 
-       pm_suspend_ignore_children(&adev->dev, true);
-
        dev->clk = devm_clk_get(&adev->dev, NULL);
        if (IS_ERR(dev->clk)) {
                dev_err(&adev->dev, "could not get i2c clock\n");
index d856bc211715e5ae466b715881494a1be0916bb5..5fda4188a9e51d6aa33613e0247e462913f7b2c4 100644 (file)
@@ -899,17 +899,6 @@ static int sh_mobile_i2c_probe(struct platform_device *dev)
        if (resource_size(res) > 0x17)
                pd->flags |= IIC_FLAG_HAS_ICIC67;
 
-       /* Enable Runtime PM for this device.
-        *
-        * Also tell the Runtime PM core to ignore children
-        * for this device since it is valid for us to suspend
-        * this I2C master driver even though the slave devices
-        * on the I2C bus may not be suspended.
-        *
-        * The state of the I2C hardware bus is unaffected by
-        * the Runtime PM state.
-        */
-       pm_suspend_ignore_children(&dev->dev, true);
        pm_runtime_enable(&dev->dev);
        pm_runtime_get_sync(&dev->dev);