]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
spi: pxa2xx: Drop extra check of platform_get_resource() returned value
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Mon, 21 Oct 2019 10:36:25 +0000 (13:36 +0300)
committerMark Brown <broonie@kernel.org>
Wed, 23 Oct 2019 16:53:32 +0000 (17:53 +0100)
The devm_ioremap_resource() has already a check for resource pointer
being NULL. No need to double check this.

Drop extra check of platform_get_resource() returned value.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20191021103625.4250-2-andriy.shevchenko@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-pxa2xx.c

index 068c210376799cee413674a65ac16e1cc8540361..4249bcaf77bdfd912addff17f2e4e263fc44ea29 100644 (file)
@@ -1545,17 +1545,15 @@ pxa2xx_spi_init_pdata(struct platform_device *pdev)
        if (!pdata)
                return NULL;
 
-       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-       if (!res)
-               return NULL;
-
        ssp = &pdata->ssp;
 
-       ssp->phys_base = res->start;
+       res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
        ssp->mmio_base = devm_ioremap_resource(&pdev->dev, res);
        if (IS_ERR(ssp->mmio_base))
                return NULL;
 
+       ssp->phys_base = res->start;
+
 #ifdef CONFIG_PCI
        if (pcidev_id) {
                pdata->tx_param = pdev->dev.parent;