]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
iwlwifi: mvm: include more debug data when we get an unexpected baid
authorEmmanuel Grumbach <emmanuel.grumbach@intel.com>
Thu, 27 Jul 2017 06:45:10 +0000 (09:45 +0300)
committerLuca Coelho <luciano.coelho@intel.com>
Fri, 18 Aug 2017 13:06:07 +0000 (16:06 +0300)
When we get a valid baid in a received frame, we need to
check that we are aware of this baid. If not, we check
that the OLD_SN bit set. If that's not the case, we issue
a WARNING. Print more data when that happens.

Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
drivers/net/wireless/intel/iwlwifi/mvm/rxmq.c

index 6b8e57b7234ac442a18ffbff9d89b068e63b22e9..4fbf102b3a985071c7c9af43379ac4a5c1d91901 100644 (file)
@@ -636,8 +636,8 @@ static bool iwl_mvm_reorder(struct iwl_mvm *mvm,
        baid_data = rcu_dereference(mvm->baid_map[baid]);
        if (!baid_data) {
                WARN(!(reorder & IWL_RX_MPDU_REORDER_BA_OLD_SN),
-                    "Received baid %d, but no data exists for this BAID\n",
-                    baid);
+                    "Received baid %d, but no data exists for this BAID - reorder data 0x%x\n",
+                    baid, reorder);
                return false;
        }
 
@@ -758,7 +758,9 @@ static void iwl_mvm_agg_rx_received(struct iwl_mvm *mvm,
 
        data = rcu_dereference(mvm->baid_map[baid]);
        if (!data) {
-               WARN_ON(!(reorder_data & IWL_RX_MPDU_REORDER_BA_OLD_SN));
+               WARN(!(reorder_data & IWL_RX_MPDU_REORDER_BA_OLD_SN),
+                    "OLD_SN isn't set, but no data exists for baid %d - reorder data 0x%x\n",
+                    baid, reorder_data);
                goto out;
        }