]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
media: staging/atomisp: make six local functions static to appease sparse
authorMuhammad Falak R Wani <falakreyaz@gmail.com>
Sat, 23 Sep 2017 19:45:34 +0000 (21:45 +0200)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Fri, 27 Oct 2017 13:37:55 +0000 (15:37 +0200)
The functions __bo_alloc, __bo_search_and_remove_from_free_rbtree,
__bo_search_by_addr, __bo_search_by_addr_in_range, __bo_break_up and
__bo_merge  are local to the source and do not need to be in the global
scope, so make them static.

Cleans up sparse warnings:

warning: symbol '__bo_alloc' was not declared. Should it be static?
warning: symbol '__bo_search_and_remove_from_free_rbtree' was not declared. Should it be static?
warning: symbol '__bo_search_by_addr' was not declared. Should it be static?
warning: symbol '__bo_search_by_addr_in_range' was not declared. Should it be static?
warning: symbol '__bo_break_up' was not declared. Should it be static?
warning: symbol '__bo_merge' was not declared. Should it be static?

Signed-off-by: Muhammad Falak R Wani <falakreyaz@gmail.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@osg.samsung.com>
drivers/staging/media/atomisp/pci/atomisp2/hmm/hmm_bo.c

index e6ddfbf0c4e2aa261839b0829a5daf136b72d270..8007b6f5017997bf0891f63ac169bdc854433d58 100644 (file)
@@ -58,7 +58,7 @@ static unsigned int nr_to_order_bottom(unsigned int nr)
        return fls(nr) - 1;
 }
 
-struct hmm_buffer_object *__bo_alloc(struct kmem_cache *bo_cache)
+static struct hmm_buffer_object *__bo_alloc(struct kmem_cache *bo_cache)
 {
        struct hmm_buffer_object *bo;
 
@@ -99,7 +99,7 @@ static int __bo_init(struct hmm_bo_device *bdev, struct hmm_buffer_object *bo,
        return 0;
 }
 
-struct hmm_buffer_object *__bo_search_and_remove_from_free_rbtree(
+static struct hmm_buffer_object *__bo_search_and_remove_from_free_rbtree(
                                struct rb_node *node, unsigned int pgnr)
 {
        struct hmm_buffer_object *this, *ret_bo, *temp_bo;
@@ -150,7 +150,7 @@ struct hmm_buffer_object *__bo_search_and_remove_from_free_rbtree(
        return temp_bo;
 }
 
-struct hmm_buffer_object *__bo_search_by_addr(struct rb_root *root,
+static struct hmm_buffer_object *__bo_search_by_addr(struct rb_root *root,
                                                        ia_css_ptr start)
 {
        struct rb_node *n = root->rb_node;
@@ -175,8 +175,8 @@ struct hmm_buffer_object *__bo_search_by_addr(struct rb_root *root,
        return NULL;
 }
 
-struct hmm_buffer_object *__bo_search_by_addr_in_range(struct rb_root *root,
-                                       unsigned int start)
+static struct hmm_buffer_object *__bo_search_by_addr_in_range(
+               struct rb_root *root, unsigned int start)
 {
        struct rb_node *n = root->rb_node;
        struct hmm_buffer_object *bo;
@@ -258,7 +258,7 @@ static void __bo_insert_to_alloc_rbtree(struct rb_root *root,
        rb_insert_color(&bo->node, root);
 }
 
-struct hmm_buffer_object *__bo_break_up(struct hmm_bo_device *bdev,
+static struct hmm_buffer_object *__bo_break_up(struct hmm_bo_device *bdev,
                                        struct hmm_buffer_object *bo,
                                        unsigned int pgnr)
 {
@@ -331,7 +331,7 @@ static void __bo_take_off_handling(struct hmm_buffer_object *bo)
        }
 }
 
-struct hmm_buffer_object *__bo_merge(struct hmm_buffer_object *bo,
+static struct hmm_buffer_object *__bo_merge(struct hmm_buffer_object *bo,
                                        struct hmm_buffer_object *next_bo)
 {
        struct hmm_bo_device *bdev;