]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
crypto: ccree - use the full crypt length value
authorGilad Ben-Yossef <gilad@benyossef.com>
Mon, 29 Jul 2019 10:40:18 +0000 (13:40 +0300)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 9 Aug 2019 05:05:30 +0000 (15:05 +1000)
In case of AEAD decryption verifcation error we were using the
wrong value to zero out the plaintext buffer leaving the end of
the buffer with the false plaintext.

Signed-off-by: Gilad Ben-Yossef <gilad@benyossef.com>
Fixes: ff27e85a85bb ("crypto: ccree - add AEAD support")
CC: stable@vger.kernel.org # v4.17+
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/ccree/cc_aead.c

index ce302adc76c74875b76887b65d2b14003bc86c7e..339fabfe3de6a4dc55646171eb4906a96ad067a1 100644 (file)
@@ -236,7 +236,7 @@ static void cc_aead_complete(struct device *dev, void *cc_req, int err)
                        /* In case of payload authentication failure, MUST NOT
                         * revealed the decrypted message --> zero its memory.
                         */
-                       cc_zero_sgl(areq->dst, areq_ctx->cryptlen);
+                       cc_zero_sgl(areq->dst, areq->cryptlen);
                        err = -EBADMSG;
                }
        /*ENCRYPT*/