]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
greybus: loopback: use the attribute groups, not group
authorGreg Kroah-Hartman <greg@kroah.com>
Tue, 31 Mar 2015 21:02:34 +0000 (23:02 +0200)
committerGreg Kroah-Hartman <greg@kroah.com>
Tue, 31 Mar 2015 21:02:34 +0000 (23:02 +0200)
We should use the attribute groups, not group, for the device, so
add and remove it.  No one should ever be updating a sysfs group for a
device, as that can be pretty dangerous if you don't duplicate _all_
existing attribute for that device, and I don't think we were doing that
here.

Signed-off-by: Greg Kroah-Hartman <greg@kroah.com>
drivers/staging/greybus/loopback.c

index 7003bce148ff77c41c3e2d6395367b28068b7c88..9914b52c71ceed0c45bb8bf9d2cece41231382ab 100644 (file)
@@ -343,7 +343,7 @@ static int gb_loopback_connection_init(struct gb_connection *connection)
 
        gb->connection = connection;
        connection->private = gb;
-       retval = sysfs_update_group(&connection->dev.kobj, &loopback_group);
+       retval = sysfs_create_groups(&connection->dev.kobj, loopback_groups);
        if (retval)
                goto error;
 
@@ -372,7 +372,7 @@ static void gb_loopback_connection_exit(struct gb_connection *connection)
 
        if (!IS_ERR_OR_NULL(gb->task))
                kthread_stop(gb->task);
-       sysfs_remove_group(&connection->dev.kobj, &loopback_group);
+       sysfs_remove_groups(&connection->dev.kobj, loopback_groups);
        kfree(gb);
 }