]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
media: cx18: update *pos correctly in cx18_read_pos()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 22 Feb 2019 06:37:02 +0000 (01:37 -0500)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Tue, 19 Mar 2019 18:00:03 +0000 (14:00 -0400)
We should be updating *pos.  The current code is a no-op.

Fixes: 1c1e45d17b66 ("V4L/DVB (7786): cx18: new driver for the Conexant CX23418 MPEG encoder chip")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/pci/cx18/cx18-fileops.c

index f778965a2eb8bdf0e5ab984189df2272bcb88163..59e78fb17575d890d92a76ae7927e7594b2f382b 100644 (file)
@@ -484,7 +484,7 @@ static ssize_t cx18_read_pos(struct cx18_stream *s, char __user *ubuf,
 
        CX18_DEBUG_HI_FILE("read %zd from %s, got %zd\n", count, s->name, rc);
        if (rc > 0)
-               pos += rc;
+               *pos += rc;
        return rc;
 }