]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
scsi: sym53c8xx_2: sym_hipd: mark expected switch fall-throughs
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Mon, 26 Nov 2018 20:14:18 +0000 (14:14 -0600)
committerGustavo A. R. Silva <gustavo@embeddedor.com>
Mon, 8 Apr 2019 23:39:08 +0000 (18:39 -0500)
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.

Addresses-Coverity-ID: 114996 ("Missing break in switch")
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
drivers/scsi/sym53c8xx_2/sym_hipd.c

index 0a2a54517b151d8d1451ba85b5d7b17366d4e6d2..054fb059926304225ee4973f8270d15b2bb33173 100644 (file)
@@ -3072,6 +3072,7 @@ static void sym_sir_bad_scsi_status(struct sym_hcb *np, int num, struct sym_ccb
                        sym_print_addr(cp->cmd, "%s\n",
                                s_status == S_BUSY ? "BUSY" : "QUEUE FULL\n");
                }
+               /* fall through */
        default:        /* S_INT, S_INT_COND_MET, S_CONFLICT */
                sym_complete_error (np, cp);
                break;
@@ -4632,6 +4633,7 @@ static void sym_int_sir(struct sym_hcb *np)
         *  Negotiation failed.
         *  Target does not want answer message.
         */
+       /* fall through */
        case SIR_NEGO_PROTO:
                sym_nego_default(np, tp, cp);
                goto out;